Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Limit scaled frame to source frame dimensions #513

Merged
merged 1 commit into from
Nov 25, 2024

Conversation

hiroshihorie
Copy link
Member

Add logic to prevent scaling up the output frames.
Scaling up the video result frames beyond the resolution of the device-provided source frames doesn’t make sense.

For example, if the device supports a maximum resolution of 1552x1552, specifying 3840x2160 will result in an output of 1552x873 (while maintaining the aspect ratio).

Copy link
Contributor

@cloudwebrtc cloudwebrtc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm!

@hiroshihorie hiroshihorie merged commit 1804bad into main Nov 25, 2024
12 checks passed
@hiroshihorie hiroshihorie deleted the hiroshi/limit-frame-scale branch November 25, 2024 12:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants